Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Actions Files #19

Merged
merged 17 commits into from
Nov 2, 2023
Merged

New Actions Files #19

merged 17 commits into from
Nov 2, 2023

Conversation

MatteoCampinoti94
Copy link
Member

  • Merged to_convert, to_convert_symphovert, to_extract, to_ignore, and to_reidentify into actions.yml
  • Added actions schema file actions.schema.json
  • Add schema test for actions.yml

@MatteoCampinoti94
to_convert.schema - add JSON schema for conversion instructions
eabb6a4
@MatteoCampinoti94
to_convert,to_convert_symphovert - convert to new schema
f7e3be7
@MatteoCampinoti94
Revert "to_convert,to_convert_symphovert - convert to new schema"
3033560 
This reverts commit f7e3be7.
@MatteoCampinoti94
Revert "to_convert.schema - add JSON schema for conversion instructions"
1e815ec 
This reverts commit eabb6a4.
@MatteoCampinoti94
actions.schema - add schema for new actions file
3a5c2ed
@MatteoCampinoti94
actions - convert existing instructions to new format
112f96f
@MatteoCampinoti94
actions - convert JSON to YAML
05d7e6e
@MatteoCampinoti94
actions - remove JSON version
0c8da32
@MatteoCampinoti94
actions - x-fmt/418.action = ignore
3096922
@MatteoCampinoti94
actions.schema - add reidentify.onfail property
6e6377e 
Sets an action to take in case of failure.
@MatteoCampinoti94
actions - fmt/111.action = reidentify
6e94ae7
@MatteoCampinoti94
actions x-fmt/13, x-fmt/111 set default action to reidentify, add cop…
c861ba3 
…y converter on reidentify failure
@MatteoCampinoti94
workflows:check-json - add checks for actions schema
758742c
@MatteoCampinoti94
workflows:check-json - set Python version to 3.11.6
dd57629
@MatteoCampinoti94
actions.schema - add rename action type
32ebe19
@MatteoCampinoti94
actions.schema - reorder action enum
d8bc1a5
@MatteoCampinoti94 MatteoCampinoti94 self-assigned this Nov 2, 2023
@MatteoCampinoti94 MatteoCampinoti94 added the enhancement New feature or request label Nov 2, 2023
clausjuhl
clausjuhl approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@clausjuhl clausjuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser godt ud! Jeg tilføjede et "description"-felt til hvert format, hvis vi skulle have behov for gemme nogen info om formatet.

@MatteoCampinoti94 MatteoCampinoti94 merged commit dea26eb into main Nov 2, 2023
1 check passed
@MatteoCampinoti94 MatteoCampinoti94 deleted the acacore-reformatting branch November 2, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clausjuhl clausjuhl clausjuhl approved these changes

Assignees

@MatteoCampinoti94 MatteoCampinoti94

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatteoCampinoti94 @clausjuhl